Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: publish to npm for master branch #308

Merged
merged 2 commits into from
Apr 1, 2022

Conversation

superflyxxi
Copy link
Contributor

Publish changes to npm repository. Calling it a feat since from what I've seen in the commits, there's been features introduced worthy of a minor version bump.

@superflyxxi superflyxxi changed the title feat: bring back publishing to npm feat: publish to npm for master branch Feb 20, 2022
@superflyxxi superflyxxi marked this pull request as ready for review February 20, 2022 15:59
@superflyxxi superflyxxi marked this pull request as draft February 20, 2022 16:00
@superflyxxi superflyxxi marked this pull request as ready for review February 22, 2022 15:24
@daniloab
Copy link
Collaborator

daniloab commented Feb 22, 2022

I don't have sure about this workflow being automated before fixing problems already known by the last version tried to be published.

@superflyxxi
Copy link
Contributor Author

I wasn't sure why it was commented out. Do you know what issue was there?

@superflyxxi
Copy link
Contributor Author

#227 is the one that commented it out, but seems unrelated. The commit specifically only has comment "turn off automated publishing for major bump". bb6a9ee

@superflyxxi
Copy link
Contributor Author

Is it possible to merge this? This repo has not had a release in over 1 year.

@daniloab daniloab merged commit 7141ec4 into Surnet:master Apr 1, 2022
@daniloab
Copy link
Collaborator

daniloab commented Apr 1, 2022

Yes, actually I'm the one looking and trying to take care of this repo.

I'm preparing to list the principal issues to be fixed and prepare the next major release for the lib.

Also, I want to publish the docs of swagger-jsdoc moving from the readme to a docusaurus page. If someone is interested in to help this feel free to contact me.

@superflyxxi superflyxxi deleted the fix/publish-to-npm branch April 1, 2022 22:03
@superflyxxi
Copy link
Contributor Author

The good news is that npm has the latest version, but github is not updated with new release version (but tag v6.2.0 is there).

npm: https://www.npmjs.com/package/swagger-jsdoc
github: https://github.com/Surnet/swagger-jsdoc/releases/tag/v6.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants